Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle and refactor alerts #1429

Merged
merged 3 commits into from
Apr 26, 2023
Merged

Restyle and refactor alerts #1429

merged 3 commits into from
Apr 26, 2023

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Apr 26, 2023

These better match Transak mocks, and not using transparency gives us better control if we need to change them

Before After
wallet oasis io_account_oasis1qqfnswjm4l5wcpc0ysz29fg4e85f6uqlasvzyl26 localhost_3000_account_oasis1qza7np2lcnggvrppgjte7n2c9gkerc5jgsnuuapg
wallet oasis io_account_oasis1qqfnswjm4l5wcpc0ysz29fg4e85f6uqlasvzyl26 (1) localhost_3000_account_oasis1qza7np2lcnggvrppgjte7n2c9gkerc5jgsnuuapg (1)

@lukaw3d lukaw3d requested a review from buberdds April 26, 2023 01:34
@github-actions
Copy link

github-actions bot commented Apr 26, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 12 0 0.06s
✅ JSON eslint-plugin-jsonc 1 0 0 1.19s
✅ JSON jsonlint 1 0 0.23s
✅ JSON npm-package-json-lint yes no 0.66s
✅ JSON prettier 1 0 0 0.7s
✅ JSON v8r 1 0 1.49s
✅ REPOSITORY checkov yes no 21.51s
✅ REPOSITORY git_diff yes no 0.01s
✅ TSX eslint 6 0 0 6.94s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@cloudflare-pages
Copy link

cloudflare-pages bot commented Apr 26, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 398a676
Status: ✅  Deploy successful!
Preview URL: https://4f4d7710.oasis-wallet.pages.dev
Branch Preview URL: https://lw-refactor-alert.oasis-wallet.pages.dev

View logs

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #1429 (398a676) into master (205ae52) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1429      +/-   ##
==========================================
+ Coverage   83.17%   83.25%   +0.07%     
==========================================
  Files         154      154              
  Lines        4018     4018              
  Branches      726      726              
==========================================
+ Hits         3342     3345       +3     
+ Misses        676      673       -3     
Flag Coverage Δ
cypress 50.89% <100.00%> (+0.01%) ⬆️
jest 78.48% <66.66%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/BuildPreviewBanner/index.tsx 100.00% <ø> (ø)
...ingPage/Features/ValidatorList/ValidatorStatus.tsx 100.00% <ø> (ø)
src/styles/theme/ThemeProvider.tsx 100.00% <ø> (ø)
src/app/components/AlertBox/index.tsx 100.00% <100.00%> (ø)
src/app/components/TransactionStatus/index.tsx 100.00% <100.00%> (ø)
...ages/AccountPage/Features/AccountSummary/index.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@lukaw3d lukaw3d merged commit 90ff351 into master Apr 26, 2023
@lukaw3d lukaw3d deleted the lw/refactor-alert branch April 26, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants