Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed transak iframe in Fiat on-ramp #1431

Merged
merged 6 commits into from May 1, 2023
Merged

Embed transak iframe in Fiat on-ramp #1431

merged 6 commits into from May 1, 2023

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Apr 27, 2023

Before: #1357
After:

Testnet Bookmarked account Acknowledge Loaded Iframe long height
localhost_3000_account_oasis1qqcu4g9dgq2ajpmeddtzessye9tvnanuws74u6rc_fiat localhost_3000_account_oasis1qqcu4g9dgq2ajpmeddtzessye9tvnanuws74u6rc_fiat (1) localhost_3000_account_oasis1qqcu4g9dgq2ajpmeddtzessye9tvnanuws74u6rc_fiat (2) localhost_3000_account_oasis1qqcu4g9dgq2ajpmeddtzessye9tvnanuws74u6rc_fiat (3) localhost_3000_account_oasis1qz02v4v8muwyhmvyw6qm8lrsu0zpggc8pv3r7lh2_fiat

@lukaw3d lukaw3d requested review from buberdds and tjanez April 27, 2023 01:54
@github-actions
Copy link

github-actions bot commented Apr 27, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 12 0 0.08s
✅ JSON eslint-plugin-jsonc 1 0 0 1.63s
✅ JSON jsonlint 1 0 0.24s
✅ JSON npm-package-json-lint yes no 0.73s
✅ JSON prettier 1 0 0 0.79s
✅ JSON v8r 1 0 2.52s
✅ REPOSITORY checkov yes no 24.01s
✅ REPOSITORY git_diff yes no 0.01s
✅ TSX eslint 5 0 0 7.17s
✅ TYPESCRIPT eslint 1 0 0 5.3s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #1431 (6722780) into master (0ec2bb7) will decrease coverage by 0.11%.
The diff coverage is 15.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1431      +/-   ##
==========================================
- Coverage   83.25%   83.14%   -0.11%     
==========================================
  Files         154      154              
  Lines        4018     4029      +11     
  Branches      726      726              
==========================================
+ Hits         3345     3350       +5     
- Misses        673      679       +6     
Flag Coverage Δ
cypress 50.76% <9.09%> (-0.14%) ⬇️
jest 78.44% <15.78%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/AlertBox/index.tsx 100.00% <ø> (ø)
src/app/pages/FiatOnramp/index.tsx 0.00% <0.00%> (ø)
src/commonRoutes.tsx 20.00% <ø> (ø)
...rc/app/components/MobileFooterNavigation/index.tsx 97.14% <100.00%> (ø)
src/app/components/Sidebar/index.tsx 88.88% <100.00%> (ø)
src/app/pages/FiatOnramp/isEnabled.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@cloudflare-pages
Copy link

cloudflare-pages bot commented May 1, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6722780
Status: ✅  Deploy successful!
Preview URL: https://08b6d067.oasis-wallet.pages.dev
Branch Preview URL: https://lw-fiat-iframe.oasis-wallet.pages.dev

View logs

@lukaw3d lukaw3d merged commit fa2b916 into master May 1, 2023
10 of 11 checks passed
@lukaw3d lukaw3d deleted the lw/fiat-iframe branch May 1, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants