Update AlertBox colors #1439
Merged
Update AlertBox colors #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Deploying with
|
| Latest commit: |
a31fc60
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://97d95762.oasis-wallet.pages.dev |
| Branch Preview URL: | https://lw-alertbox-colors.oasis-wallet.pages.dev |
Codecov Report
@@ Coverage Diff @@
## master #1439 +/- ##
==========================================
- Coverage 83.02% 82.92% -0.10%
==========================================
Files 154 154
Lines 4029 4042 +13
Branches 726 728 +2
==========================================
+ Hits 3345 3352 +7
- Misses 684 690 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lukaw3d
force-pushed
the
lw/alertbox-colors
branch
from
0120652
to
a20a107
Compare
lukaw3d
force-pushed
the
lw/alertbox-colors
branch
from
a20a107
to
5655b17
Compare
buberdds
reviewed
May 9, 2023
| }, | ||
| 'alert-box-error-background': { | ||
| dark: '#ffe7d9', | ||
| light: '#f26111', |
There was a problem hiding this comment.
Can we align text color as well? otherwise light/error will fail accessibility color contrast with current #444. Mocks are using diff font color.
There was a problem hiding this comment.
Let's do that in a separate PR. I think the font color change applies everywhere
src/styles/theme/ThemeProvider.tsx
Outdated
| light: '#f3d45e', | ||
| }, | ||
| 'alert-box-error': { | ||
| dark: '#d24c00', |
There was a problem hiding this comment.
oops, seems to have changed
| }, | ||
| 'alert-box-warning': { | ||
| dark: '#f3d45e', | ||
| light: '#f0e8cb', |
There was a problem hiding this comment.
I think that's a bug on mocks - border #F3D45E should match the icon #f0e8cb
This reverts commit 3a0faf7 and re-implements it so multiline alerts like /create-wallet on a phone are not stretched out.
lukaw3d
force-pushed
the
lw/alertbox-colors
branch
from
1a86bf7
to
a31fc60
Compare
buberdds
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.figma.com/file/G6EVdJhfGbDBZRdpWnUyC7/Wallet-Design-System?type=design&node-id=22-1429&t=E44uYOZqmDSuC2xp-0