Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor banners and show them based on domain so same build can be deployed to production #1447

Merged
merged 4 commits into from May 11, 2023

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented May 9, 2023

This should be mirrored in explorer too

@lukaw3d lukaw3d requested a review from buberdds May 9, 2023 16:54
@cloudflare-pages
Copy link

cloudflare-pages bot commented May 9, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c891f0f
Status: ✅  Deploy successful!
Preview URL: https://42b11381.oasis-wallet.pages.dev
Branch Preview URL: https://lw-banners.oasis-wallet.pages.dev

View logs

@github-actions
Copy link

github-actions bot commented May 9, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 10 0 0.05s
✅ JSON eslint-plugin-jsonc 2 0 0 0.89s
✅ JSON jsonlint 2 0 0.18s
✅ JSON npm-package-json-lint yes no 0.51s
✅ JSON prettier 2 0 0 0.63s
✅ JSON v8r 2 0 5.52s
✅ REPOSITORY checkov yes no 18.26s
✅ REPOSITORY git_diff yes no 0.0s
✅ TSX eslint 3 0 0 4.22s
✅ TYPESCRIPT eslint 2 0 0 3.94s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@lukaw3d lukaw3d changed the title Refactor banners and show them based on location so same build can be deployed to prod Refactor banners and show them based on domain so same build can be deployed to production May 9, 2023
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #1447 (64acca4) into master (5054130) will decrease coverage by 0.09%.
The diff coverage is 90.90%.

❗ Current head 64acca4 differs from pull request most recent head c891f0f. Consider uploading reports for the commit c891f0f to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1447      +/-   ##
==========================================
- Coverage   82.98%   82.90%   -0.09%     
==========================================
  Files         154      154              
  Lines        4037     4041       +4     
  Branches      725      726       +1     
==========================================
  Hits         3350     3350              
- Misses        687      691       +4     
Flag Coverage Δ
cypress 50.91% <87.50%> (+0.01%) ⬆️
jest 78.03% <90.90%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/BuildBanner/index.tsx 93.75% <85.71%> (ø)
src/app/index.tsx 100.00% <100.00%> (ø)
src/styles/theme/elementSizes.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants