Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix badge counter z-index being above preview banner #1448

Merged
merged 1 commit into from May 10, 2023

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented May 9, 2023

Refactored using grommet's badge on a button that doesn't use z-index

Before After
localhost_3000_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km_stake (5) localhost_3000_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km_stake (3)
localhost_3000_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km_stake (4) localhost_3000_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km_stake (2)

@lukaw3d lukaw3d requested a review from buberdds May 9, 2023 18:20
@github-actions
Copy link

github-actions bot commented May 9, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 4 0 0.02s
✅ REPOSITORY checkov yes no 20.22s
✅ REPOSITORY git_diff yes no 0.0s
✅ TSX eslint 2 0 0 5.27s
✅ TYPESCRIPT eslint 1 0 0 4.61s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@cloudflare-pages
Copy link

cloudflare-pages bot commented May 9, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c362e8f
Status: ✅  Deploy successful!
Preview URL: https://51fb12b3.oasis-wallet.pages.dev
Branch Preview URL: https://lw-simplify-badge.oasis-wallet.pages.dev

View logs

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #1448 (c1d124c) into master (e29d708) will increase coverage by 0.13%.
The diff coverage is 100.00%.

❗ Current head c1d124c differs from pull request most recent head c362e8f. Consider uploading reports for the commit c362e8f to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1448      +/-   ##
==========================================
+ Coverage   82.85%   82.99%   +0.13%     
==========================================
  Files         154      154              
  Lines        4042     4039       -3     
  Branches      728      726       -2     
==========================================
+ Hits         3349     3352       +3     
+ Misses        693      687       -6     
Flag Coverage Δ
cypress 50.89% <ø> (-0.02%) ⬇️
jest 78.15% <100.00%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/styles/theme/ThemeProvider.tsx 100.00% <ø> (ø)
src/styles/theme/elementSizes.ts 100.00% <ø> (ø)
src/app/pages/AccountPage/index.tsx 97.40% <100.00%> (-0.07%) ⬇️

... and 1 file with indirect coverage changes

@lukaw3d lukaw3d enabled auto-merge May 10, 2023 12:38
@lukaw3d lukaw3d merged commit f9b96e1 into master May 10, 2023
9 checks passed
@lukaw3d lukaw3d deleted the lw/simplify-badge branch May 10, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants