Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle Transak: put warning and widget into its own Box #1469

Merged
merged 2 commits into from May 19, 2023

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented May 18, 2023

Fixes #1456

Before After
localhost_3000_split (4) localhost_3000_split (2)
localhost_3000_split localhost_3000_split (3)

cc @donouwens

@lukaw3d lukaw3d requested review from buberdds and tjanez May 18, 2023 16:25
@github-actions
Copy link

github-actions bot commented May 18, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 1 0 0.01s
✅ REPOSITORY checkov yes no 20.59s
✅ REPOSITORY git_diff yes no 0.0s
✅ TSX eslint 1 0 0 4.77s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #1469 (a72e8aa) into master (b624d0a) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

❗ Current head a72e8aa differs from pull request most recent head 776f4ac. Consider uploading reports for the commit 776f4ac to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1469      +/-   ##
==========================================
- Coverage   83.10%   83.02%   -0.08%     
==========================================
  Files         154      154              
  Lines        4042     4042              
  Branches      726      726              
==========================================
- Hits         3359     3356       -3     
- Misses        683      686       +3     
Flag Coverage Δ
cypress 51.11% <0.00%> (ø)
jest 78.04% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/pages/FiatOnramp/index.tsx 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@cloudflare-pages
Copy link

cloudflare-pages bot commented May 19, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 776f4ac
Status: ✅  Deploy successful!
Preview URL: https://9d2e1061.oasis-wallet.pages.dev
Branch Preview URL: https://lw-transak-layout.oasis-wallet.pages.dev

View logs

@lukaw3d lukaw3d enabled auto-merge May 19, 2023 13:41
@lukaw3d lukaw3d merged commit 4c998cd into master May 19, 2023
9 checks passed
@lukaw3d lukaw3d deleted the lw/transak-layout branch May 19, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should Transak widget have more contrast in light mode?
2 participants