Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encourage decentralization by shuffling validators on every load #1517

Merged
merged 1 commit into from Jun 27, 2023

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Jun 27, 2023

Fixes #766

@lukaw3d lukaw3d requested a review from buberdds June 27, 2023 13:31
@github-actions
Copy link

github-actions bot commented Jun 27, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 3 0 0.02s
✅ JSON eslint-plugin-jsonc 1 0 0 1.18s
✅ JSON jsonlint 1 0 0.2s
✅ JSON npm-package-json-lint yes no 0.63s
✅ JSON prettier 1 0 0 0.54s
✅ JSON v8r 1 0 4.29s
✅ REPOSITORY checkov yes no 20.82s
✅ REPOSITORY git_diff yes no 0.01s
✅ TYPESCRIPT eslint 1 0 0 5.21s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1ff127b
Status: ✅  Deploy successful!
Preview URL: https://db911438.oasis-wallet.pages.dev
Branch Preview URL: https://lw-shuffle-validators.oasis-wallet.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #1517 (1ff127b) into master (09b75b0) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1517      +/-   ##
==========================================
- Coverage   83.23%   83.11%   -0.12%     
==========================================
  Files         155      155              
  Lines        4051     4052       +1     
  Branches      728      728              
==========================================
- Hits         3372     3368       -4     
- Misses        679      684       +5     
Flag Coverage Δ
cypress 51.12% <ø> (ø)
jest 78.24% <100.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/state/staking/saga.ts 88.17% <100.00%> (+0.12%) ⬆️

... and 2 files with indirect coverage changes

@lukaw3d lukaw3d merged commit cd0da5d into master Jun 27, 2023
13 checks passed
@lukaw3d lukaw3d deleted the lw/shuffle-validators branch June 27, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorder validators to encourage decentralization
2 participants