Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sandbox to Transak iframe to block top-navigation #1585

Merged
merged 1 commit into from Aug 10, 2023

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Aug 9, 2023

we now have: Content-Security-Policy, Permissions-Policy, allow=, sandbox=

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 2 0 0.02s
✅ REPOSITORY checkov yes no 45.37s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 15.71s
✅ REPOSITORY trivy-sbom yes no 3.16s
✅ REPOSITORY trufflehog yes no 92.28s
✅ TSX eslint 1 0 0 5.9s
✅ TYPESCRIPT eslint 1 0 0 5.84s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@cloudflare-pages
Copy link

cloudflare-pages bot commented Aug 9, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8f10875
Status: ✅  Deploy successful!
Preview URL: https://d383e881.oasis-wallet.pages.dev
Branch Preview URL: https://lw-block-top-navigation.oasis-wallet.pages.dev

View logs

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #1585 (8f10875) into master (81ca9e7) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1585      +/-   ##
==========================================
+ Coverage   82.91%   83.01%   +0.09%     
==========================================
  Files         157      157              
  Lines        4069     4069              
  Branches      729      729              
==========================================
+ Hits         3374     3378       +4     
+ Misses        695      691       -4     
Flag Coverage Δ
cypress 51.17% <ø> (ø)
jest 78.11% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/app/pages/FiatOnrampPage/index.tsx 0.00% <ø> (ø)

... and 2 files with indirect coverage changes

@lukaw3d lukaw3d merged commit cfcf72b into master Aug 10, 2023
13 checks passed
@lukaw3d lukaw3d deleted the lw/block-top-navigation branch August 10, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants