Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign towards settings page #1630

Merged
merged 10 commits into from Sep 5, 2023
Merged

Redesign towards settings page #1630

merged 10 commits into from Sep 5, 2023

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Sep 4, 2023

Before After
wallet stg oasis io_account_oasis1qzhdcgu4uacm4hk8gavas4yhvky70402ws3q89du localhost_3000_account_oasis1qzhdcgu4uacm4hk8gavas4yhvky70402ws3q89du
localhost_3000_account_oasis1qzhdcgu4uacm4hk8gavas4yhvky70402ws3q89du (1)
Screenshot from 2023-09-04 19-50-22

@cloudflare-pages
Copy link

cloudflare-pages bot commented Sep 4, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ebf5792
Status: ✅  Deploy successful!
Preview URL: https://11200a0a.oasis-wallet.pages.dev
Branch Preview URL: https://lw-to-support-settings.oasis-wallet.pages.dev

View logs

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 17 0 0.08s
✅ JSON eslint-plugin-jsonc 1 0 0 0.89s
✅ JSON jsonlint 1 0 0.22s
✅ JSON npm-package-json-lint yes no 0.59s
✅ JSON prettier 1 0 0 0.44s
✅ JSON v8r 1 0 1.62s
✅ REPOSITORY checkov yes no 37.73s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY grype yes no 11.5s
✅ REPOSITORY trivy-sbom yes no 2.1s
✅ REPOSITORY trufflehog yes no 137.33s
✅ TSX eslint 12 0 0 6.25s
✅ TYPESCRIPT eslint 2 0 0 5.71s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #1630 (8eeebd5) into master (e1713fa) will decrease coverage by 0.09%.
The diff coverage is 85.85%.

❗ Current head 8eeebd5 differs from pull request most recent head ebf5792. Consider uploading reports for the commit ebf5792 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1630      +/-   ##
==========================================
- Coverage   82.95%   82.86%   -0.09%     
==========================================
  Files         157      161       +4     
  Lines        4089     4150      +61     
  Branches      733      743      +10     
==========================================
+ Hits         3392     3439      +47     
- Misses        697      711      +14     
Flag Coverage Δ
cypress 51.17% <76.27%> (+0.11%) ⬆️
jest 77.85% <79.79%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../Features/SettingsButton/addressToJazzIconSeed.tsx 100.00% <ø> (ø)
...nts/Toolbar/Features/Account/ManageableAccount.tsx 68.96% <68.96%> (ø)
...mponents/Toolbar/Features/SettingsButton/index.tsx 91.42% <85.71%> (ø)
...pp/components/Toolbar/Features/Account/Account.tsx 91.17% <91.17%> (ø)
src/app/components/AddressBox/index.tsx 100.00% <100.00%> (ø)
...s/Toolbar/Features/Account/DerivationFormatter.tsx 100.00% <100.00%> (ø)
...nts/Toolbar/Features/Account/ImportableAccount.tsx 100.00% <100.00%> (ø)
...ponents/Toolbar/Features/AccountSelector/index.tsx 100.00% <100.00%> (ø)
src/app/components/Toolbar/index.tsx 100.00% <100.00%> (ø)
src/app/lib/helpers.ts 79.72% <100.00%> (+0.27%) ⬆️
... and 1 more

@lukaw3d lukaw3d force-pushed the lw/to-support-settings branch 2 times, most recently from 89b3cfe to 8eeebd5 Compare September 4, 2023 20:13
onClickManage: () => setLayerVisibility(true),
}}
/>
{layerVisibility && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am already following this convention while working on Address Book, but the problem is that sizes are not matching always
Screenshot 2023-09-05 at 18 26 17

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes; i'm not sure it's a problem after positioning it "top" instead of center

modal
position="top"
margin={isMobile ? 'none' : 'xlarge'}

@lukaw3d lukaw3d merged commit 87ab442 into master Sep 5, 2023
11 checks passed
@lukaw3d lukaw3d deleted the lw/to-support-settings branch September 5, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants