Fix layout issues #1713
Merged
Fix layout issues #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
50a97db
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2798cd86.oasis-wallet.pages.dev |
| Branch Preview URL: | https://mz-responsivelayerfix.oasis-wallet.pages.dev |
buberdds
force-pushed
the
mz/ResponsiveLayerFix
branch
from
4763fc1
to
ee92b30
Compare
Codecov Report
@@ Coverage Diff @@
## master #1713 +/- ##
=======================================
Coverage 82.97% 82.97%
=======================================
Files 179 179
Lines 4587 4587
Branches 819 820 +1
=======================================
Hits 3806 3806
Misses 781 781
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lukaw3d
reviewed
Oct 12, 2023
| <Box fill={isMobile}>{props.children}</Box> | ||
| <Box | ||
| // Prevents Grommet flex overlap issue in smaller viewport | ||
| flex={{ shrink: 0 }} |
There was a problem hiding this comment.
this doesn't behave the same in landscape
| Before https://mz-settings.oasis-wallet.pages.dev/ | After https://mz-responsivelayerfix.oasis-wallet.pages.dev/ |
|---|---|
 |
 |
There was a problem hiding this comment.
switched to maxHeight. Seems better now.
buberdds
force-pushed
the
mz/ResponsiveLayerFix
branch
from
ee92b30
to
2fcdafc
Compare
buberdds
force-pushed
the
mz/ResponsiveLayerFix
branch
from
2fcdafc
to
50a97db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1710