Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bluetooth Ledger state #1739

Merged
merged 5 commits into from Nov 21, 2023
Merged

Conversation

lubej
Copy link
Collaborator

@lubej lubej commented Oct 20, 2023

No description provided.

@lubej lubej force-pushed the bluetooth-state branch 5 times, most recently from 3e2771d to 08500f4 Compare October 20, 2023 14:17
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #1739 (d223dcf) into master (2705c73) will decrease coverage by 0.06%.
Report is 1 commits behind head on master.
The diff coverage is 74.02%.

❗ Current head d223dcf differs from pull request most recent head 46c8061. Consider uploading reports for the commit 46c8061 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1739      +/-   ##
==========================================
- Coverage   81.98%   81.92%   -0.06%     
==========================================
  Files         186      186              
  Lines        4828     4884      +56     
  Branches      887      897      +10     
==========================================
+ Hits         3958     4001      +43     
- Misses        870      883      +13     
Flag Coverage Δ
cypress 47.54% <12.30%> (-0.55%) ⬇️
jest 77.59% <71.42%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/app/components/ErrorFormatter/index.tsx 100.00% <ø> (ø)
...p/components/ImportAccountsStepFormatter/index.tsx 100.00% <ø> (ø)
...s/Toolbar/Features/Account/DerivationFormatter.tsx 100.00% <ø> (ø)
src/app/lib/ledger.ts 95.94% <100.00%> (+0.42%) ⬆️
src/app/pages/ConnectDevicePage/index.tsx 100.00% <100.00%> (ø)
src/app/state/transaction/saga.ts 73.29% <100.00%> (+1.68%) ⬆️
src/types/errors.ts 82.85% <100.00%> (+0.50%) ⬆️
...pages/OpenWalletPage/Features/FromLedger/index.tsx 77.27% <0.00%> (ø)
...ge/Features/ImportAccountsSelectionModal/index.tsx 91.80% <0.00%> (ø)
src/app/state/importaccounts/selectors.ts 95.45% <80.00%> (-4.55%) ⬇️
... and 2 more

@lubej lubej force-pushed the bluetooth-state branch 2 times, most recently from 11af5c6 to 3c812c8 Compare October 20, 2023 14:30
@lubej lubej changed the title Bluetooth state Add Bluetooth Ledger state Oct 20, 2023
@lubej lubej marked this pull request as ready for review October 20, 2023 14:53
@@ -2,10 +2,13 @@ import { BalanceDetails } from '../account/types'

export enum WalletType {
Ledger = 'ledger',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming this in another separate PR

src/app/lib/ledger.ts Show resolved Hide resolved
src/app/state/transaction/saga.test.ts Outdated Show resolved Hide resolved
@lubej lubej force-pushed the bluetooth-state branch 2 times, most recently from 0b4e502 to 4257eb7 Compare November 2, 2023 08:31
@lubej lubej requested a review from lukaw3d November 2, 2023 08:31
@lubej lubej merged commit d5c9e2c into oasisprotocol:master Nov 21, 2023
7 of 8 checks passed
@lubej lubej mentioned this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants