Restyle V0 extension migration UI #1790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1790 +/- ##
==========================================
- Coverage 81.45% 81.44% -0.01%
==========================================
Files 190 191 +1
Lines 5062 5067 +5
Branches 934 930 -4
==========================================
+ Hits 4123 4127 +4
- Misses 939 940 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lukaw3d
force-pushed
the
lw/restyle-migration
branch
4 times, most recently
from
56c2aff
to
e2e0ecc
Compare
buberdds
approved these changes
Dec 6, 2023
| /> | ||
| )} | ||
| {acknowledge && <PrivateKeyFormatter privateKey={wallet.privateKey!} />} | ||
| <RevealOverlayButton |
There was a problem hiding this comment.
That kinda sucks because priv key is in DOM already without acknowledge.
There was a problem hiding this comment.
Mocks even show the underlying element blurred, but I think blur might be reversible in screenshots
|
Should we consider moving Transak tests out of CI to some nightly build/tests in the near future? |
lukaw3d
force-pushed
the
lw/restyle-migration
branch
from
e2e0ecc
to
325bcf6
Compare
Maybe yeah |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mocks: