Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase desktop profile modal width to match pre #1796 width #1805

Merged
merged 1 commit into from Dec 18, 2023

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Dec 15, 2023

The difference on Ubuntu with scrollbars is: optional scrollbar (15px) + margin (24px + 24px) = 63px
Without scrollbars the whole account address would still fit in one line.

Before #1796 Now After
localhost_3000_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km localhost_3000_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km (1) localhost_3000_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km (2)

@lukaw3d lukaw3d changed the title Increase desktop profile modal width to match before dbb5d8e Increase desktop profile modal width to match before #1796 Dec 15, 2023
Copy link

github-actions bot commented Dec 15, 2023

Deployed to Cloudflare Pages

Latest commit: ec0e42af7976dc3e2854a5896b3663d8df5a7ccf
Status:✅ Deploy successful!
Preview URL: https://79d1e26b.oasis-wallet.pages.dev

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #1805 (697859f) into master (6e67efd) will decrease coverage by 0.03%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 697859f differs from pull request most recent head ec0e42a. Consider uploading reports for the commit ec0e42a to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1805      +/-   ##
==========================================
- Coverage   81.47%   81.44%   -0.03%     
==========================================
  Files         191      191              
  Lines        5046     5071      +25     
  Branches      924      931       +7     
==========================================
+ Hits         4111     4130      +19     
- Misses        935      941       +6     
Flag Coverage Δ
cypress 45.89% <100.00%> (-0.17%) ⬇️
jest 77.33% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...mponents/Toolbar/Features/LayerContainer/index.tsx 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

@lukaw3d lukaw3d changed the title Increase desktop profile modal width to match before #1796 Increase desktop profile modal width to match pre #1796 width Dec 15, 2023
The difference is: optional scrollbar (15px) + margin (24px + 24px) = 63px
@lukaw3d lukaw3d merged commit f81f490 into master Dec 18, 2023
10 checks passed
@lukaw3d lukaw3d deleted the lw/modal-width branch December 18, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants