Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hiding body scrollbar in Chrome extension and nested layers #1811

Merged
merged 1 commit into from Dec 20, 2023

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Dec 19, 2023

Part of it is related to #863 issue with nested layers

Before After
Screenshot from 2023-12-19 04-42-24 Screenshot from 2023-12-19 04-41-58
localhost_3000_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km(extension360x600) localhost_3000_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km(extension360x600) (1)

Copy link

github-actions bot commented Dec 19, 2023

Deployed to Cloudflare Pages

Latest commit: 9a6c414a5b7cfc3abe17a4441eaa60b9eb34bd00
Status:✅ Deploy successful!
Preview URL: https://6376fc57.oasis-wallet.pages.dev

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (21ceaf6) 81.35% compared to head (9a6c414) 81.45%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1811      +/-   ##
==========================================
+ Coverage   81.35%   81.45%   +0.09%     
==========================================
  Files         191      191              
  Lines        5048     5048              
  Branches      926      926              
==========================================
+ Hits         4107     4112       +5     
+ Misses        941      936       -5     
Flag Coverage Δ
cypress 46.02% <ø> (ø)
jest 77.35% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/app/components/ResponsiveLayer/index.tsx 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

@lukaw3d lukaw3d merged commit ea3084b into master Dec 20, 2023
11 of 12 checks passed
@lukaw3d lukaw3d deleted the lw/fix-hiding-scrollbars branch December 20, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants