Allow quotes when typing 'delete' #1951
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
lubej
approved these changes
May 24, 2024
| @@ -21,7 +21,9 @@ export function DeleteInputForm({ children, onCancel, onConfirm }: DeleteInputFo | |||
| <FormField | |||
| name="type_delete" | |||
| validate={(value: string | undefined) => | |||
| !value || value.toLowerCase() !== t('deleteForm.confirmationKeyword', 'delete').toLowerCase() | |||
| !value || | |||
| value.toLowerCase().replace(/['"“”]/g, '') !== | |||
There was a problem hiding this comment.
Doesn't this enable you to write '''''''''delete'''''''''?
There was a problem hiding this comment.
Also '''''d'e''l'e''t'e''''' would be possible. But I guess it doesn't matter in the end.
There was a problem hiding this comment.
I would personally rather see we remove apostrophes entirely. And mark the text different(italic, bold), that is supposed to be written down in confirmation dialog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since our instructions are
To confirm and proceed, please type 'delete' below.