Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: protect validator-media-info from xss attacks #199

Merged
merged 1 commit into from Aug 23, 2021

Conversation

Esya
Copy link
Contributor

@Esya Esya commented Jul 21, 2021

Fixes #185

@github-actions
Copy link

github-actions bot commented Jul 21, 2021

Mega-Linter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 5 0 1.38s
✅ GIT git_diff yes no 0.01s
✅ JSON eslint-plugin-jsonc 1 0 0 0.99s
✅ JSON jsonlint 1 0 0.29s
✅ JSON prettier 1 0 0 0.53s
✅ JSON v8r 1 0 0.91s
✅ TSX eslint 2 0 0 5.05s

See errors details in artifact Mega-Linter reports on GitHub Action page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #199 (3dfcda1) into develop (79e214b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #199      +/-   ##
===========================================
+ Coverage    90.89%   90.90%   +0.01%     
===========================================
  Files           95       95              
  Lines         1537     1539       +2     
  Branches       263      265       +2     
===========================================
+ Hits          1397     1399       +2     
  Misses         140      140              
Flag Coverage Δ
cypress 64.55% <0.00%> (-0.09%) ⬇️
jest 74.50% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../StakingPage/Features/ValidatorMediaInfo/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79e214b...3dfcda1. Read the comment docs.

@Esya Esya merged commit 5c88efd into develop Aug 23, 2021
@Esya Esya deleted the fix/protect-xss-validator-media-info branch August 23, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validator information allows XSS through URLs
2 participants