Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using consensusGetGenesisDocument #698

Merged
merged 4 commits into from Feb 23, 2022
Merged

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Feb 23, 2022

Genesis rarely changes, and it is pretty heavy.

Switch to consensusGetChainContext, stakingTokenSymbol, and hardcode min_delegation stakingConsensusParameters

@github-actions
Copy link

github-actions bot commented Feb 23, 2022

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 1 0 0.06s
✅ EDITORCONFIG editorconfig-checker 6 0 0.6s
✅ GIT git_diff yes no 0.06s
✅ TSX eslint 1 0 0 4.42s
✅ TYPESCRIPT eslint 3 0 0 4.57s
✅ YAML prettier 2 0 0 1.2s
✅ YAML v8r 2 0 1.88s
✅ YAML yamllint 2 0 0.16s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@lukaw3d lukaw3d changed the title Avoid consensusGetGenesisDocument Avoid using consensusGetGenesisDocument Feb 23, 2022
src/app/state/network/saga.ts Outdated Show resolved Hide resolved
Copy link
Member

@tjanez tjanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very beneficial for lowering the gRPC server load!
Thanks, @lukaw3d!

@pro-wh
Copy link
Contributor

pro-wh commented Feb 23, 2022

fixes #280

@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #698 (bd4cf6f) into develop (fe3ee2b) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #698      +/-   ##
===========================================
+ Coverage    88.18%   88.27%   +0.09%     
===========================================
  Files           99       99              
  Lines         1616     1612       -4     
  Branches       306      305       -1     
===========================================
- Hits          1425     1423       -2     
+ Misses         191      189       -2     
Flag Coverage Δ
cypress 60.19% <100.00%> (+0.02%) ⬆️
jest 73.67% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/state/network/index.ts 92.30% <ø> (ø)
src/app/state/network/saga.ts 95.45% <100.00%> (+6.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe3ee2b...bd4cf6f. Read the comment docs.

@lukaw3d lukaw3d merged commit 1813e21 into develop Feb 23, 2022
@lukaw3d lukaw3d deleted the lw/dont-get-genesis branch February 23, 2022 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants