Sort validators by validator status property #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #757 +/- ##
========================================
Coverage 88.02% 88.02%
========================================
Files 99 99
Lines 1628 1628
Branches 312 312
========================================
Hits 1433 1433
Misses 195 195
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
lukaw3d
reviewed
Mar 16, 2022
lukaw3d
reviewed
Mar 16, 2022
lukaw3d
approved these changes
Mar 16, 2022
buberdds
force-pushed
the
750-sort-validators
branch
from
a90acce
to
2c10d11
Compare
lukaw3d
reviewed
Mar 16, 2022
lukaw3d
reviewed
Mar 16, 2022
buberdds
force-pushed
the
750-sort-validators
branch
from
2c10d11
to
f17e499
Compare
buberdds
force-pushed
the
750-sort-validators
branch
from
f17e499
to
6ac24f3
Compare
lukaw3d
approved these changes
Mar 17, 2022
src/vendors/helpers.ts
Outdated
| inactive: 2, | ||
| } | ||
|
|
||
| export const sortByStatus = (a, b) => ValidatorStatusPriority[a.status] - ValidatorStatusPriority[b.status] |
There was a problem hiding this comment.
Hm, our typescript allows parameters to not be typed? Will need to reconfigure that
buberdds
force-pushed
the
750-sort-validators
branch
from
6ac24f3
to
37ea17c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #750
my preference here is to go with memoized selector, another option would be to use DataTable sortFunction prop. UX would be the same.
0