Show list of ParaTime transactions #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaw3d
reviewed
Jun 6, 2022
ghost
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
buberdds
force-pushed
the
ysz/paratimes
branch
4 times, most recently
from
7e52326
to
ce78036
Compare
|
@lukaw3d can you look at PR again? I've fixed a few issues. I am not sure what's the best way to handle props that are missing for paratime transaction. Is there a way to make response data more similar for consensus and paratimes transactions (some query params maybe?)? |
|
Doesn't look like oasisscan can return better data. We should just show the remaining data as unknown, and give feedback for oasis-indexer |
buberdds
force-pushed
the
ysz/paratimes
branch
3 times, most recently
from
ea0078f
to
fec921e
Compare
buberdds
force-pushed
the
ysz/paratimes
branch
3 times, most recently
from
dbd6150
to
5654ed0
Compare
lukaw3d
approved these changes
Aug 1, 2022
lukaw3d
reviewed
Aug 2, 2022
| [transactionTypes.TransactionType.ConsensusDeposit]: { | ||
| [TransactionSide.Received]: { | ||
| destination: t('common.from', 'From'), | ||
| icon: () => <Inherit color="#FFCA58" />, |
There was a problem hiding this comment.
This doesn't go well with
const Icon = matchingConfiguration.icon
...
<Icon size={isMobile ? '20px' : 'medium'} color="brand" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shows list of ParaTime transactions in the existing Transaction list for Oasis account.
This is part of #791 which would consist of 1-2 more upcoming PRs. See tasks here #791 (comment)