Prevent race conditions when loading account

[buberdds]

Closes #861

[github-actions]

MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ EDITORCONFIG	editorconfig-checker	6		0	0.02s
✅ GIT	git_diff	yes		no	0.01s
✅ TYPESCRIPT	eslint	6	0	0	5.91s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

[codecov]

Codecov Report

Merging #868 (0766178) into master (4f12054) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #868      +/-   ##
==========================================
+ Coverage   88.29%   88.41%   +0.12%     
==========================================
  Files          97       97              
  Lines        1606     1606              
  Branches      336      336              
==========================================
+ Hits         1418     1420       +2     
+ Misses        188      186       -2     

Flag	Coverage Δ
cypress	60.72% <85.71%> (ø)
jest	74.67% <85.71%> (+0.12%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/app/state/account/saga.ts	69.04% <100.00%> (ø)
src/app/state/network/saga.ts	100.00% <100.00%> (+8.69%)	⬆️
src/app/state/staking/saga.ts	93.82% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f12054...0766178. Read the comment docs.

[lukaw3d]

I don't think this is a useful test.

I'd rather see approximately

expectSaga(stakingSaga)
  .provide(getAccount, () => delay(10*Math.random()))
  .put(fetchAccount('a'))
  .put(fetchAccount('b'))
  .hasFinalState({ address: 'b' })
  .run()

[buberdds]

I think this unit test if valid unless I am missing something, but I am following one of redux saga test plan pattern. I am adding a unit test not integration test. Unit test is testing a watcher saga only and it doesn't care about integration with other parts of code. The bug exists because of using a wrong effect creator. Unit test is validating if a correct effect creator is used so it covers current bug/potential regression bug.

[lukaw3d]

This unit test is essentially "did source code change" and it will break on many non-regressions.

expect(accountSaga.toString()).toBe(`
  export function* accountSaga() {
    yield* fork(refreshAccountOnTransaction)
    yield* takeLatest(actions.fetchAccount, loadAccount)
  }
`)

testSaga becomes interesting when unit testing with different inputs in .next(_), so it tests behavior, instead of implementation.