Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sidebar external links #903

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Fix Sidebar external links #903

merged 1 commit into from
Jul 6, 2022

Conversation

buberdds
Copy link
Contributor

@buberdds buberdds commented Jul 4, 2022

Follows to #821

  • for regular anchors, external links we cannot use react-router navigation. Example link from prod https://wallet.oasisprotocol.org/https://github.com/oasisprotocol/oasis-wallet-web

@github-actions
Copy link

github-actions bot commented Jul 4, 2022

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 2 0 0.01s
✅ GIT git_diff yes no 0.01s
✅ TSX eslint 1 0 0 5.32s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #903 (7ead841) into master (1bbf579) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 7ead841 differs from pull request most recent head 4266ed2. Consider uploading reports for the commit 4266ed2 to get more accurate results

@@           Coverage Diff           @@
##           master     #903   +/-   ##
=======================================
  Coverage   87.53%   87.53%           
=======================================
  Files          98       98           
  Lines        1620     1621    +1     
  Branches      347      348    +1     
=======================================
+ Hits         1418     1419    +1     
  Misses        202      202           
Flag Coverage Δ
cypress 60.28% <100.00%> (+0.02%) ⬆️
jest 73.85% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Sidebar/index.tsx 89.18% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bbf579...4266ed2. Read the comment docs.

@buberdds buberdds requested a review from lukaw3d July 6, 2022 10:51
@@ -691,7 +707,8 @@ exports[`<Navigation /> should match snapshot 1`] = `
/>
<a
aria-label="GitHub"
href="/https://github.com/oasisprotocol/oasis-wallet-web"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, that was terrible

src/app/components/Sidebar/index.tsx Outdated Show resolved Hide resolved
src/app/components/Sidebar/index.tsx Outdated Show resolved Hide resolved
@buberdds buberdds merged commit 9158bda into master Jul 6, 2022
@buberdds buberdds deleted the buberdds/fixSidebarLink branch July 6, 2022 20:48
@lukaw3d
Copy link
Member

lukaw3d commented Jul 11, 2022

oops github link is green now:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants