Test our type-safe replacements #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaLinter status: ✅ SUCCESS
See errors details in artifact MegaLinter reports on CI Job page |
buberdds
approved these changes
Jul 8, 2022
| ).toBeDefined() | ||
| }) | ||
|
|
||
| it('detect mistakes', () => { |
There was a problem hiding this comment.
I don't mind merging this, but what's a real value of these tests ? For example this test is testing a case which is impossible to implement, because TS will throw an error. How any of these tests can fail ?
There was a problem hiding this comment.
This ensures that typescript will throw an error. E.g. if we change our type definition or bump typescript, our constraints could become less strict without us noticing otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #911