Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated vscode extensions from recommendations #919

Merged
merged 2 commits into from Jul 11, 2022

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Jul 11, 2022

No description provided.

@lukaw3d lukaw3d requested a review from buberdds July 11, 2022 16:41
@github-actions
Copy link

github-actions bot commented Jul 11, 2022

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 3 0 0.02s
✅ GIT git_diff yes no 0.01s
✅ JSON eslint-plugin-jsonc 2 0 0 1.19s
✅ JSON jsonlint 2 0 0.67s
✅ JSON prettier 2 0 0 0.71s
✅ JSON v8r 2 0 5.31s
✅ TYPESCRIPT eslint 1 0 0 6.53s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@@ -2,8 +2,6 @@
"recommendations": [
"dbaeumer.vscode-eslint",
"esbenp.prettier-vscode",
"msjsdiag.debugger-for-chrome",
"eg2.vscode-npm-script",
"jpoissonnier.vscode-styled-components",
Copy link
Contributor

@buberdds buberdds Jul 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is deprecated as well. It is replaced by
https://github.com/styled-components/vscode-styled-components

The jpoissonnier.vscode-styled-components version will recieve no more updates.. It was removed from marketplace.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, removed :/ maybe that's why vscode didn't warn me about it.

Replacing with styled-components.vscode-styled-components

@lukaw3d lukaw3d merged commit a6ac88c into master Jul 11, 2022
@lukaw3d lukaw3d deleted the lw/vs-recommend branch July 11, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants