Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark failed transactions #925

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Mark failed transactions #925

merged 1 commit into from
Jul 13, 2022

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Jul 12, 2022

Fixes #924

Before After
before after

@github-actions
Copy link

github-actions bot commented Jul 12, 2022

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 3 0 0.02s
✅ GIT git_diff yes no 0.01s
✅ JSON eslint-plugin-jsonc 1 0 0 0.84s
✅ JSON jsonlint 1 0 0.23s
✅ JSON prettier 1 0 0 0.51s
✅ JSON v8r 1 0 0.99s
✅ TSX eslint 2 0 0 5.78s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #925 (6636801) into master (4d70db9) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 6636801 differs from pull request most recent head 8108033. Consider uploading reports for the commit 8108033 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #925      +/-   ##
==========================================
+ Coverage   87.56%   87.58%   +0.02%     
==========================================
  Files          97       97              
  Lines        1616     1619       +3     
  Branches      350      353       +3     
==========================================
+ Hits         1415     1418       +3     
  Misses        201      201              
Flag Coverage Δ
cypress 57.82% <0.00%> (-0.11%) ⬇️
jest 74.31% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Transaction/index.tsx 77.77% <100.00%> (+1.58%) ⬆️

@buberdds
Copy link
Contributor

I personally would go with header bg color or badge/Tag

Screenshot 2022-07-13 at 11 11 41
Screenshot 2022-07-13 at 11 11 14
Screenshot 2022-07-13 at 08 26 16

@lukaw3d
Copy link
Member Author

lukaw3d commented Jul 13, 2022

Going with header bg color because tags are annoying in grommet

Updated screenshot localhost_3000_account_oasis1qz78ap0456g2rk7j6rmtvasc9v2kjhz2s58qgj90

@lukaw3d lukaw3d merged commit a242c5e into master Jul 13, 2022
@lukaw3d lukaw3d deleted the lw/failed-tx branch July 13, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Differentiate failed transactions
2 participants