-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor dispatching transactions so "Reclaim all" doesn't lose more precision #932
Conversation
amount: props.maxAmount, | ||
shares: props.shares, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No rounding 🎉
This comment was marked as resolved.
This comment was marked as resolved.
|
b93a1a6
to
ea1fb6e
Compare
Oh, we lose precision when parsing from API.. |
Will revisit in another year. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea
ea1fb6e
to
e65f95a
Compare
Codecov Report
@@ Coverage Diff @@
## master #932 +/- ##
==========================================
- Coverage 88.32% 88.31% -0.01%
==========================================
Files 97 97
Lines 1679 1678 -1
Branches 387 387
==========================================
- Hits 1483 1482 -1
Misses 196 196
Flags with carried forward coverage won't be shown. Click here to find out more.
|
e65f95a
to
422b4f4
Compare
422b4f4
to
2eb4203
Compare
No description provided.