Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change UI to be more similar to current extension: footer #933

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

buberdds
Copy link
Contributor

  • add fixed menu to footer
  • tweak footer css for mobile

Screenshot 2022-07-14 at 15 17 07
Screenshot 2022-07-14 at 15 17 13

@github-actions
Copy link

github-actions bot commented Jul 14, 2022

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 5 0 0.01s
✅ GIT git_diff yes no 0.01s
✅ TSX eslint 4 0 0 6.71s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #933 (6b1b0d7) into master (a62273b) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #933      +/-   ##
==========================================
+ Coverage   87.59%   87.74%   +0.15%     
==========================================
  Files          97       98       +1     
  Lines        1620     1640      +20     
  Branches      353      358       +5     
==========================================
+ Hits         1419     1439      +20     
  Misses        201      201              
Flag Coverage Δ
cypress 58.06% <76.19%> (+0.21%) ⬆️
jest 74.52% <100.00%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Footer/index.tsx 100.00% <100.00%> (ø)
...rc/app/components/MobileFooterNavigation/index.tsx 100.00% <100.00%> (ø)

Copy link
Member

@lukaw3d lukaw3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

src/app/components/Footer/index.tsx Outdated Show resolved Hide resolved
src/app/components/Footer/index.tsx Show resolved Hide resolved
src/app/components/Footer/__tests__/index.test.tsx Outdated Show resolved Hide resolved
src/app/components/Footer/index.tsx Outdated Show resolved Hide resolved
src/app/components/MobileFooterNavigation/index.tsx Outdated Show resolved Hide resolved
src/app/components/MobileFooterNavigation/index.tsx Outdated Show resolved Hide resolved
@buberdds buberdds merged commit fe1790a into master Jul 15, 2022
@buberdds buberdds deleted the buberdds/mobileFooter branch July 15, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants