-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change UI to be more similar to current extension: App Header #936
Conversation
MegaLinter status: ✅ SUCCESS
See errors details in artifact MegaLinter reports on CI Job page |
d7e5bf8
to
02672dc
Compare
Codecov Report
@@ Coverage Diff @@
## master #936 +/- ##
==========================================
- Coverage 88.04% 88.01% -0.03%
==========================================
Files 98 97 -1
Lines 1664 1635 -29
Branches 370 362 -8
==========================================
- Hits 1465 1439 -26
+ Misses 199 196 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
src/app/components/Toolbar/Features/AccountSelectorButton/index.tsx
Outdated
Show resolved
Hide resolved
useEffect(() => { | ||
if (ref?.current) { | ||
const icon = jazzicon(diameter, seed) | ||
|
||
ref.current.replaceChildren() | ||
ref.current.appendChild(icon) | ||
} | ||
}, [diameter, ref, seed]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the recommended react way to append HTML elements?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What other option I have to inject DOM elements generated by 3rd party, not react lib? I think it's Ok that's what metamask is doing for example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep yep. I can't find docs for the recommended way 🤷
eaa5ff3
to
f442611
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new icon avatar/switcher looks great!
I would remove the search box completely.
59eb24c
to
a4e1247
Compare
a4e1247
to
cb61cb9
Compare
Main requirements were:
with search
![Screenshot 2022-07-19 at 11 06 13](https://user-images.githubusercontent.com/891392/179723090-722f5c93-39e1-4d25-a152-cc65b93b65a6.png)
without search
![Screenshot 2022-07-19 at 11 07 13](https://user-images.githubusercontent.com/891392/179723250-1c4810fd-9a00-4106-844f-e648d5f9a8be.png)
with dynamic account icon
![Screenshot 2022-07-19 at 11 07 58](https://user-images.githubusercontent.com/891392/179723355-327aa000-1a98-4105-ab09-e9571af08896.png)
![Screenshot 2022-07-19 at 11 07 51](https://user-images.githubusercontent.com/891392/179723346-ebab3705-2bd4-44e6-9e1f-9cc56704e800.png)