Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change UI to be more similar to current extension: Account Page subnav #937

Merged
merged 1 commit into from
Jul 23, 2022

Conversation

buberdds
Copy link
Contributor

PR updates styles of Transaction List subnav. Once merge I will have to sync translations files via Transifex. In next iteration this menu will be moved from Account to Stake page.

Screenshot 2022-07-19 at 18 33 50
Screenshot 2022-07-19 at 18 33 43

Screenshot 2022-07-19 at 18 33 17
Screenshot 2022-07-19 at 18 31 55

@github-actions
Copy link

github-actions bot commented Jul 19, 2022

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 6 0 0.04s
✅ GIT git_diff yes no 0.01s
✅ JSON eslint-plugin-jsonc 4 0 0 1.07s
✅ JSON jsonlint 4 0 1.1s
✅ JSON prettier 4 0 0 0.69s
✅ JSON v8r 4 0 2.66s
✅ TSX eslint 1 0 0 5.62s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #937 (6571e87) into master (f30f00e) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #937      +/-   ##
==========================================
+ Coverage   88.12%   88.16%   +0.03%     
==========================================
  Files          97       97              
  Lines        1651     1656       +5     
  Branches      367      370       +3     
==========================================
+ Hits         1455     1460       +5     
  Misses        196      196              
Flag Coverage Δ
cypress 58.65% <83.33%> (-0.06%) ⬇️
jest 79.00% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/pages/AccountPage/index.tsx 98.00% <100.00%> (+0.22%) ⬆️

@buberdds buberdds requested review from tjanez and lukaw3d July 20, 2022 06:06
Copy link
Member

@tjanez tjanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. And yes, we should move that under the staking tab/subpage in the next iteration.

src/app/pages/AccountPage/index.tsx Outdated Show resolved Hide resolved
src/app/pages/AccountPage/index.tsx Outdated Show resolved Hide resolved
src/app/pages/AccountPage/index.tsx Outdated Show resolved Hide resolved
@buberdds buberdds force-pushed the buberdds/transactionListMenu branch from 8c59971 to 6571e87 Compare July 23, 2022 07:04
@buberdds buberdds merged commit bea9e22 into master Jul 23, 2022
@buberdds buberdds deleted the buberdds/transactionListMenu branch July 23, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants