-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display estimated debonding time in debonding list #963
Conversation
MegaLinter status: ✅ SUCCESS
See errors details in artifact MegaLinter reports on CI Job page |
Codecov Report
@@ Coverage Diff @@
## master #963 +/- ##
==========================================
+ Coverage 88.50% 88.58% +0.07%
==========================================
Files 98 99 +1
Lines 1697 1708 +11
Branches 392 396 +4
==========================================
+ Hits 1502 1513 +11
Misses 195 195
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
||
const estimatedEpochsPerHour = 1 | ||
|
||
const relativeFormat = new Intl.RelativeTimeFormat(process?.env?.NODE_ENV === 'test' ? 'en-US' : undefined) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The downside is that we loose multi lang support. It will show EN labels no matter what lang user is using.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either way it's not in sync with app lang. Mixing langs is a bit weird, but in this case it is still better than epoch number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a very good point 😓
created #965
Related to #420