sidebar: Change language icon for consistency with docs #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaLinter status: ✅ SUCCESS
See errors details in artifact MegaLinter reports on CI Job page |
matevz
force-pushed
the
matevz/feature/language-icon
branch
4 times, most recently
from
312945c
to
9fb060a
Compare
Codecov Report
@@ Coverage Diff @@
## master #999 +/- ##
==========================================
+ Coverage 88.69% 88.71% +0.01%
==========================================
Files 100 101 +1
Lines 1752 1754 +2
Branches 405 405
==========================================
+ Hits 1554 1556 +2
Misses 198 198
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lukaw3d
reviewed
Sep 15, 2022
src/app/components/Sidebar/__tests__/__snapshots__/index.test.tsx.snap
Outdated
Show resolved
Hide resolved
matevz
force-pushed
the
matevz/feature/language-icon
branch
6 times, most recently
from
e5d5634
to
57c22d5
Compare
matevz
force-pushed
the
matevz/feature/language-icon
branch
from
57c22d5
to
2a9b08c
Compare
lukaw3d
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The globe icon currently used to switch languages in the web wallet is used for visiting the oasisprotocol.org website in docs (docs.oasis.io). This PR replaces the globe icon in the wallet with the more appropriate language icon for consistency with the docs.
The new language icon was copied over from the docusaurus.io framework where it's officially used for picking the website language (read languageicon.org for the story behind the icon design).