Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Oasis CLI in sapphire-dev Docker image #488

Merged
merged 2 commits into from Dec 7, 2023

Conversation

abukosek
Copy link
Contributor

@abukosek abukosek commented Dec 6, 2023

Fixes #487.

Note that in the long-term this should really be fixed in the CLI repo instead :) Apparently, this will break Ledger support, so we must keep this workaround just inside the Docker images, as they don't need Ledger support.

@kostko
Copy link
Member

kostko commented Dec 6, 2023

Note that in the long-term this should really be fixed in the CLI repo instead :)

Building with CGO_ENABLED=0 will break Ledger support in the CLI AFAIK in which case this is not doable.

@abukosek
Copy link
Contributor Author

abukosek commented Dec 6, 2023

Building with CGO_ENABLED=0 will break Ledger support in the CLI AFAIK in which case this is not doable.

Oh, OK, we can keep this workaround just here then.

@abukosek abukosek force-pushed the andrej/bugfix/oasis-cli-in-docker branch from c5d4af6 to 8e62a74 Compare December 6, 2023 17:43
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8c4dfee) 61.86% compared to head (37e7a57) 61.86%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #488   +/-   ##
=======================================
  Coverage   61.86%   61.86%           
=======================================
  Files          37       37           
  Lines        3920     3920           
=======================================
  Hits         2425     2425           
  Misses       1288     1288           
  Partials      207      207           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abukosek
Copy link
Contributor Author

abukosek commented Dec 6, 2023

Do we need Oasis CLI to work in the emerald-dev Docker image as well?

@CedarMist
Copy link
Member

CedarMist commented Dec 6, 2023

I don't think many (any?) people are using the Emerald container, and if none of the CI tests are using it then I'd say no.

Likewise with Ledger support, it's highly unlikely that Ledger will be used with the Oasis CLI within the sapphire-dev docker container.

@abukosek abukosek force-pushed the andrej/bugfix/oasis-cli-in-docker branch from 8e62a74 to 6b899c7 Compare December 7, 2023 08:47
@CedarMist CedarMist self-requested a review December 7, 2023 11:03
Copy link
Member

@CedarMist CedarMist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works fine :)

# /oasis --version
Software version: v0.7.1-gitbcbf421
Oasis SDK version: v0.7.1
Oasis Core version: v0.2300.9
Go toolchain version: go1.21.3
sapphire-dev local (oasis-core: 23.0.9, sapphire-paratime: 0.7.0-testnet, oasis-web3-gateway: 4.0.0-git6b899c7)

I guess we can do the version bump to Sapphire 0.7.0 (not testnet) too?

@abukosek abukosek force-pushed the andrej/bugfix/oasis-cli-in-docker branch from 0779841 to 37e7a57 Compare December 7, 2023 11:29
@abukosek abukosek merged commit e68e050 into main Dec 7, 2023
8 checks passed
@abukosek abukosek deleted the andrej/bugfix/oasis-cli-in-docker branch December 7, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alpine based docker can't run the bundled Oasis CLI
3 participants