Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow empty to field in eth_call to simulate contract deploy #546

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

CedarMist
Copy link
Member

@CedarMist CedarMist commented Mar 27, 2024

Depends on #550

  • allows empty to field in eth_call
  • requires sapphire-paratime 0.7.2-testnet or above
  • adds tests for errors on contract constructor (only for Sapphire)
  • makes local testing easier with bind-mounted /tmp/eth-runtime-test/ to /serverdir/node/
  • changes port & network in conf/tests.yml so tests can be run against sapphire-localnet` instance (with above bind-mount)

Bugs found:

  • Gas estimation of contract creation is too low, can't eth_call same message with the gas estimate provided
  • Emerald runtime hasn't had an updated release, so new contract constructor tests will fail on Emerald

Why this PR?

  • The hardhat-ignition deterministic deployment framework relies on simulating contract creations using eth_call

@CedarMist CedarMist force-pushed the CedarMist/eth_call-deployment branch 4 times, most recently from 79182c5 to d0c01b5 Compare March 31, 2024 16:35
@CedarMist CedarMist self-assigned this Mar 31, 2024
@CedarMist CedarMist force-pushed the CedarMist/eth_call-deployment branch 4 times, most recently from ea591ca to 86c2efa Compare April 1, 2024 00:10
@CedarMist CedarMist marked this pull request as ready for review April 1, 2024 00:17
tests/rpc/tx_test.go Outdated Show resolved Hide resolved
@ptrus
Copy link
Member

ptrus commented Apr 1, 2024

makes local testing easier with bind-mounted /tmp/eth-runtime-test/ to /serverdir/node/

Can you add a short note somewhere, maybe into README, on the workflow for local testing with this.

@CedarMist CedarMist force-pushed the CedarMist/eth_call-deployment branch from 86c2efa to c0685ef Compare April 2, 2024 08:55
@CedarMist CedarMist requested a review from ptrus April 2, 2024 08:56
Copy link
Member

@ptrus ptrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, very nice!

@CedarMist CedarMist force-pushed the CedarMist/eth_call-deployment branch from c0685ef to 7bd3760 Compare April 2, 2024 10:10
@CedarMist CedarMist merged commit e74287d into main Apr 2, 2024
6 checks passed
@CedarMist CedarMist deleted the CedarMist/eth_call-deployment branch April 2, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants