Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cachedSignedCalls for re-use signatures for repeated signed calls #100

Merged
merged 9 commits into from
Jun 13, 2023

Conversation

xmzheng
Copy link
Contributor

@xmzheng xmzheng commented Jan 11, 2023

add a cacheManager to signed_calls so that we can cache signatures for those repeated signed calls

@xmzheng xmzheng requested a review from nhynes January 11, 2023 08:00
Copy link
Contributor

@nhynes nhynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start. I made some comments around making the cache algorithm more amenable to more secure values of blockRange.

clients/js/src/signed_calls.ts Outdated Show resolved Hide resolved
clients/js/src/signed_calls.ts Outdated Show resolved Hide resolved
clients/js/src/signed_calls.ts Outdated Show resolved Hide resolved
clients/js/src/signed_calls.ts Outdated Show resolved Hide resolved
clients/js/src/signed_calls.ts Outdated Show resolved Hide resolved
clients/js/src/signed_calls.ts Outdated Show resolved Hide resolved
clients/js/src/signed_calls.ts Outdated Show resolved Hide resolved
clients/js/src/signed_calls.ts Outdated Show resolved Hide resolved
clients/js/src/signed_calls.ts Outdated Show resolved Hide resolved
clients/js/src/signed_calls.ts Outdated Show resolved Hide resolved
@xmzheng xmzheng merged commit d9dca00 into main Jun 13, 2023
12 checks passed
@xmzheng xmzheng deleted the xmzheng/cacheSignedCall branch June 13, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants