Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump oasislabs/hardhat to 2.16.1 #144

Merged
merged 4 commits into from Jun 30, 2023
Merged

Conversation

xmzheng
Copy link
Contributor

@xmzheng xmzheng commented Jun 30, 2023

bump the oasislabs/hardhat version so it should be compatible with hardhat 2.16.1

@xmzheng xmzheng requested review from nhynes and CedarMist June 30, 2023 00:57
Copy link
Member

@CedarMist CedarMist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The https://github.com/oasislabs/hardhat repo hasn't changed while a new version of @oasislabs/hardhat has been pushed up to npmjs for 2.16.1.

Does the oasislabs/hardhat repo represent what's on npmjs?

@xmzheng
Copy link
Contributor Author

xmzheng commented Jun 30, 2023

The https://github.com/oasislabs/hardhat repo hasn't changed while a new version of @oasislabs/hardhat has been pushed up to npmjs for 2.16.1.

Does the oasislabs/hardhat repo represent what's on npmjs?

the correct repo is: https://github.com/oasislabs/NomicFoundation-hardhat/blob/main/packages/hardhat-core/package.json#L3

@xmzheng xmzheng requested a review from CedarMist June 30, 2023 14:18
@CedarMist
Copy link
Member

When this is merged we will be compatible with Hardhat 2.16.

People using previous versions must upgrade their project to Hardhat 2.16

@xmzheng xmzheng requested a review from CedarMist June 30, 2023 15:15
Copy link
Member

@CedarMist CedarMist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So now the integrations/hardhat (@oasisprotocol/sapphire-hardhat) package will track the minimum version of hardhat that it's targeting.

@xmzheng xmzheng merged commit 54ca5fc into main Jun 30, 2023
13 checks passed
@xmzheng xmzheng deleted the xmzheng/bump-oasis-hardhat-version branch June 30, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants