Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with ecrecover #145

Merged
merged 19 commits into from Jul 5, 2023

Conversation

CedarMist
Copy link
Member

@CedarMist CedarMist commented Jul 2, 2023

Fixes #138

  • Added EthereumUtils.sol + tests for ecrecover compatibility
  • Upgraded Hardhat in /contracts/ to 2.16.1
  • Works with CI tests using sapphire-dev

TODO?

  • Should probably rename EthereumUtils to SignatureUtils or something?

Lots of inconsequential changes which were since rolled-back, due to #146 when having runner & sapphire-dev in different containers on the same network. Reverted tests to run on the host while sapphire-dev listens on localhost.

@CedarMist CedarMist marked this pull request as ready for review July 5, 2023 13:39
@CedarMist CedarMist self-assigned this Jul 5, 2023
@CedarMist CedarMist requested a review from nhynes July 5, 2023 13:46
contracts/contracts/EthereumUtils.sol Outdated Show resolved Hide resolved
contracts/contracts/EthereumUtils.sol Outdated Show resolved Hide resolved
contracts/contracts/EthereumUtils.sol Show resolved Hide resolved
@CedarMist CedarMist merged commit 339166d into oasisprotocol:main Jul 5, 2023
14 checks passed
@CedarMist CedarMist deleted the CedarMist/138-ecrecover branch July 5, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ethereum ecrecover compatibility with Secp256k1PrehashedKeccak256
2 participants