Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Migrate Sapphire documentation from oasisprotocol/docs #227

Merged
merged 2 commits into from Nov 27, 2023

Conversation

matevz
Copy link
Member

@matevz matevz commented Nov 24, 2023

This PR migrates topic-oriented Sapphire documentation from https://github.com/oasisprotocol/docs/tree/main/docs/dapp/sapphire to this repository. The README file is still kept inside the docs repository to be consistent with Emerald and Cipher.

Preview

Copy link
Member

@CedarMist CedarMist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok this looks good, all the docs here are self-contained

@matevz
Copy link
Member Author

matevz commented Nov 24, 2023

Ok this looks good, all the docs here are self-contained

Actually there is one .svg image referenced in sapphire/guide.mdx with a relative ../../general/images/architecture/... path and it caused me some gray hair. It is not rendered, if viewed from github directly as a standalone documentation and I didn't find an elegant way around it using our cross-repo referencing preprocessor.

@matevz matevz force-pushed the matevz/docs/migrate-sapphire-docs branch 2 times, most recently from c7703c6 to fffe52c Compare November 27, 2023 13:06
@matevz matevz force-pushed the matevz/docs/migrate-sapphire-docs branch from fffe52c to 94c649b Compare November 27, 2023 13:10
@matevz matevz merged commit 60cfe61 into main Nov 27, 2023
13 checks passed
@matevz matevz deleted the matevz/docs/migrate-sapphire-docs branch November 27, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants