Add wrappers for signature precompiles to Sapphire library #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhynes
approved these changes
Oct 31, 2022
nhynes
reviewed
Nov 3, 2022
contracts/contracts/Sapphire.sol
Outdated
| * @param seed The seed to use for generating the key pair. | ||
| * @return (publicKey, privateKey) The generated key pair. | ||
| */ | ||
| function generateKeyPair(uint method, bytes memory seed) internal view returns (bytes memory publicKey, bytes memory privateKey) { |
There was a problem hiding this comment.
Suggested change
| function generateKeyPair(uint method, bytes memory seed) internal view returns (bytes memory publicKey, bytes memory privateKey) { | |
| enum SigningAlg { | |
| Unknown, | |
| Ed25519, | |
| Secp256k1, | |
| Sr25519 | |
| } | |
| struct SigningKey { | |
| SigningAlg alg, | |
| bytes public, | |
| bytes private | |
| } | |
| function generateSigningKey(SigningAlg alg, bytes memory seed) internal view returns (SigningKey memory key) { |
nhynes
reviewed
Nov 3, 2022
nhynes
force-pushed
the
jberci/feature/signing-precompiles
branch
from
6e133e6
to
f92779b
Compare
|
Thanks @jberci! I'll shepherd this PR from here since I made a number of changes to the precompile ABIs. |
nhynes
force-pushed
the
jberci/feature/signing-precompiles
branch
2 times, most recently
from
a2483a3
to
dbf6527
Compare
nhynes
force-pushed
the
nhynes/pc-wraps
branch
from
7c8888f
to
db5cb37
Compare
nhynes
force-pushed
the
jberci/feature/signing-precompiles
branch
2 times, most recently
from
de8b335
to
102ceb3
Compare
nhynes
force-pushed
the
jberci/feature/signing-precompiles
branch
from
102ceb3
to
efe4522
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrappers for the precompiles added in oasisprotocol/oasis-sdk#1176.