Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Japanese translations #32

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Conversation

alexeyvy
Copy link
Contributor

Ticket

https://oat-sa.atlassian.net/browse/CGF-427

Summary

Japanese translations fixed

How to test (guide shared across the related PRs)

  1. Apply all 11 PRs from the ticket
  2. taoInstall with the following extensions:
  • taoCe
  • ltiProctoring
  • taotestCenter
  • taoAltResultStorage
  • taoBlueprints
  • taoClientRestrict
  • taoColorContrast
  • taoOutcomeRds
  • taoResourceWorkflow
  • taoTaskQueue
  • taoThemingPlatform
  • xmlEditRp
  1. Go to the BO, publish a new delivery and check its property ‘Allow Proctoring’ is in English
  2. You may find the other places to check in the ticket
  3. Now revert all PRs, taoInstall with the same extension list, verify the bug actually reproduces

@github-actions
Copy link

Version

Target Version 3.1.1
Last version 3.1.0

There are 0 BREAKING CHANGE, 0 feature, 1 fix

Copy link
Contributor

@tikhanovichA tikhanovichA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master

@alexeyvy alexeyvy merged commit 0800f93 into develop Aug 30, 2021
@alexeyvy alexeyvy deleted the fix/CGF-427/japanese-translations branch August 30, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants