Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update methods to lodash 4 version #44

Closed
wants to merge 3 commits into from

Conversation

taopkorczak
Copy link

Related: https://oat-sa.atlassian.net/browse/ADF-1579
Update lodash methods to version 4.
Documentation: https://github.com/lodash/lodash/wiki/Migrating

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5e9c1f7) 2.82% compared to head (081f036) 2.82%.
Report is 6 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##             develop     #44   +/-   ##
=========================================
  Coverage       2.82%   2.82%           
  Complexity       117     117           
=========================================
  Files              7       7           
  Lines            389     389           
=========================================
  Hits              11      11           
  Misses           378     378           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@Nicholass Nicholass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I see from pull/248 we are not storing .idea files in repos.

Code is good 👍

Copy link

Version

Target Version 3.2.2
Last version 3.2.1

There are 0 BREAKING CHANGE, 0 feature, 2 fixes

Copy link

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
83 83 0 0

Copy link
Member

@wazelin wazelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks.. empty. Shall we just reject it?

@oatymart oatymart removed their request for review February 8, 2024 08:59
@olga-kulish olga-kulish removed their request for review February 9, 2024 06:51
@wazelin wazelin closed this Apr 3, 2024
@wazelin wazelin deleted the feature/ADF-1579/update-lodash-to-4 branch April 3, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants