Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/nex 664/google spanner support #262

Merged
merged 5 commits into from
Feb 11, 2020
Merged

Feature/nex 664/google spanner support #262

merged 5 commits into from
Feb 11, 2020

Conversation

boajer
Copy link
Contributor

@boajer boajer commented Jan 27, 2020

@boajer boajer marked this pull request as ready for review January 27, 2020 09:33
@mike-ionut-mihai-sandu-tao
Copy link
Contributor

mike-ionut-mihai-sandu-tao commented Jan 29, 2020 •
edited
Loading

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

mike-ionut-mihai-sandu-tao
mike-ionut-mihai-sandu-tao reviewed Jan 29, 2020
View reviewed changes
model/storage/Sql.php
* @param mixed $value
* @return float|int|string
*/
private function castValue($field, $value)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if possible please don't forget to unit test this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests added, please review

@mike-ionut-mihai-sandu-tao mike-ionut-mihai-sandu-tao merged commit ede2524 into develop Feb 11, 2020
@mike-ionut-mihai-sandu-tao mike-ionut-mihai-sandu-tao deleted the feature/NEX-664/google_spanner_support branch February 11, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-ionut-mihai-sandu-tao mike-ionut-mihai-sandu-tao mike-ionut-mihai-sandu-tao approved these changes

Assignees

@mike-ionut-mihai-sandu-tao mike-ionut-mihai-sandu-tao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@boajer @mike-ionut-mihai-sandu-tao