Feature/tr 701/use browserlist to validate approved browsers draft interface list #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wsers' into feature/TR-701/use-browserlist-to-validate-approved-browsers-DRAFT-interface-list Conflicts: model/CompatibilityChecker.php
jsconan
reviewed
Sep 28, 2021
There was a problem hiding this comment.
The proposal looks very nice, thank you for this great job.
Unfortunately there is one small glitch, please see my comment below.
Once this is addressed, I still have the error No implementation setup for oat\taoClientDiagnostic\model\SupportedList\CachedListDecorator. Maybe is something that is missing on my install, or an initialisation that is not done.
Co-authored-by: Jean-Sébastien CONAN <jean-sebastien@taotesting.com>
…wsers' into feature/TR-701/use-browserlist-to-validate-approved-browsers-DRAFT-interface-list Conflicts: model/CompatibilityChecker.php
…wsers-DRAFT-interface-list' of https://github.com/oat-sa/extension-tao-clientdiag into feature/TR-701/use-browserlist-to-validate-approved-browsers-DRAFT-interface-list
jsconan
merged commit b761bdc
into
feature/TR-701/use-browserlist-to-validate-approved-browsers
jsconan
deleted the
feature/TR-701/use-browserlist-to-validate-approved-browsers-DRAFT-interface-list
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: https://oat-sa.atlassian.net/browse/TR-701
Original PR: #297
Feature