[FIX] [ADF-1075] Do not allow to import classes on LTI Consumer Root Class #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This Root class by default does not allow to create classes via interface, but on the import was possible. After this implementation this will not be allowed anymore. Only Resources will be imported. Exception for the root class. If it is present in the rdf, it will be ignored Refs: https://oat-sa.atlassian.net/browse/ADF-1075
andreluizmachado
changed the title
andreluizmachado
requested review from
pribi,
bartlomiejmarszal,
pnal and
Karol-Stelmaczonek
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #389 +/- ##
=============================================
+ Coverage 30.59% 31.09% +0.49%
- Complexity 817 834 +17
=============================================
Files 104 106 +2
Lines 2853 2914 +61
=============================================
+ Hits 873 906 +33
- Misses 1980 2008 +28
☔ View full report in Codecov by Sentry. |
Version
There are 0 BREAKING CHANGE, 0 feature, 4 fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Root class by default does not allow to create classes via interface, but on the import was possible. After this implementation this will not be allowed anymore. Only Resources will be imported. Exception for the root class. If it is present in the rdf, it will be ignored
Refs: https://oat-sa.atlassian.net/browse/ADF-1075
Demo
resources.mov
mixed.mov
classes.mov