Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DI container services availability during install #395

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

mccar
Copy link
Contributor

@mccar mccar commented Nov 16, 2023

Ticket - https://oat-sa.atlassian.net/browse/REL-1326

Goal

DI container services availability during install

Changelog

  • feat: DI container services availability during install
  • feat: added the ability to configure the run DI container registered service->method as part extension install process.

How to test

Configure extension manifest install section with parameter 'containerRebuild' => true,
Debug one of install->php classes to check the availability of some DI services registered in the provider from containerServiceProviders
Run setup to debug
docker exec -it studio-phpfpm php tao/scripts/taoSetup.php /var/docker-stack-cli/setup.json -vvv

To check the ability to run DI container registered service->method configured in the manifest.php file you should add some service to section [install][php] in this format:

            [
                'service' => SomeServiceClass::class,
                'method' => 'methodName',
                'arguments' => ['argument1', ...]
            ]       

containerRebuild must be set to true for this extension

@codecov-commenter
Copy link

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (5b8b02f) 30.59% compared to head (ec86c72) 30.28%.
Report is 5 commits behind head on develop.

Files Patch % Lines
controller/AuthoringTool.php 0.00% 27 Missing ⚠️
...els/classes/ServiceProvider/LtiServiceProvider.php 0.00% 8 Missing ⚠️
...epository/Lti1p3RegistrationSnapshotRepository.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #395      +/-   ##
=============================================
- Coverage      30.59%   30.28%   -0.32%     
- Complexity       817      822       +5     
=============================================
  Files            104      104              
  Lines           2853     2883      +30     
=============================================
  Hits             873      873              
- Misses          1980     2010      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Version

Target Version 15.15.0
Last version 15.14.1

There are 0 BREAKING CHANGE, 2 features, 0 fix

@vbyndych vbyndych removed their request for review March 13, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants