Fix/nex 336/schema change action abstraction #101
Conversation
…ema-change-action-abstraction
mike-ionut-mihai-sandu-tao
requested review from
mike-ionut-mihai-sandu-tao and
boajer
| try { | ||
| $this->writeSchema($oldSchema, $newSchema); | ||
| } catch (DBALException $e) { | ||
| Logger::w($e->getMessage()); |
There was a problem hiding this comment.
Do you think you can inject LoggerService and avoid usage of deprecated static methods?
| try { | ||
| $table = $this->resultStorage->$creationMethodName($schema); | ||
| } catch (SchemaException $exception) { | ||
| // Table already exists. How can this happen, since we're doing this because |
There was a problem hiding this comment.
please remove comments and add logger->error('')
| try { | ||
| $table = $schema->getTable($tableName); | ||
| } catch (SchemaException $exception) { | ||
| try { |
There was a problem hiding this comment.
please add log here as well
| * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | ||
| * | ||
| * Copyright (c) 2014-2017 (original work) Open Assessment Technologies SA (under the project TAO-PRODUCT); | ||
| * |
There was a problem hiding this comment.
for consistency, please remove the extra 2 lines at the end of the license
| protected $persistence; | ||
|
|
||
| /** | ||
| * @param $params |
There was a problem hiding this comment.
i would specify the type
| * | ||
| * @return Report | ||
| */ | ||
| public function __invoke($params) |
There was a problem hiding this comment.
not used, and no default value
| */ | ||
| private function readSchema() | ||
| { | ||
| /** @var \common_persistence_sql_dbal_SchemaManager $schemaManager */ |
There was a problem hiding this comment.
fqn simplified please
| { | ||
| } | ||
|
|
||
| protected function getActionName() |
There was a problem hiding this comment.
do we really need this? it's a protected function that returns a constant, if yes maybe put it at the AbstractAction level
julien-sebire
changed the base branch from
feature/NEX-168/uuid-primary-keys
to
develop
This PR aims at proposing an abstraction for schema modification actions.
It has two levels of abstraction: