add unique constraint to variables storage #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tikhanovichA
approved these changes
Jul 31, 2019
|
Good job. |
bugalot
requested changes
Jul 31, 2019
There was a problem hiding this comment.
I think there is a misunderstanding
First, with that PR, I will not be able to give the same anwser to two different items in the same delivery execution, which is a problem.
If I have two items with textEntryInteraction, and respond "myanswer" to each of them, we will get one missing result.
On the other hand, the problem is not exactly that. It's only, in the context of synchronization of a VM to the central server.
Last year we had duplicated results while re syncing that's what we need to reproduce. Maybe it was because of multiple Web Servers for the central server?
|
@bugalot could you approve changes, please? |
zagovorichev
suggested changes
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose: avoid duplicated in results storage.
Implementation: add unique constraint to variables storage
Made a performance test with/without that unique index:
Env: https://act-test.taocloud.org
Users: 100
Ramp-up: 10 sec
Test size: 8 items
table size: 5,607,787 records
The difference is no more than 3% which is within the margin of error:
No index:
With index:
