fix: do not show dialog when choosing file #246
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to https://oat-sa.atlassian.net/browse/TR-1327
Description
When testTaker selects a file to upload, the dialog is shown that testTaker leaves fullscreen.
The file cannot be uploaded without leaving fullscreen (please keep in mind the difference between fullscreen mode activated by user clicking fullscreen icon in browser menu window and application-initiated fullscreen mode).
The initial intention was to implement the following flow:
Unfortunately that implementation of this flow is not possible due to browser security standards because entering fullscreen has to be initiated by some user interaction like click (https://developer.mozilla.org/en-US/docs/Web/API/Element/requestFullScreen). So we need to display dialog again once we are back from file selection to make user click ok button to enter fullscreen.
However we can show the dialog "Test should be taken in fullscreen mode" only when file selection dialog is closed and that is implemented in the PR
How to test
Enable fullscreen security plugin and set it for delivery. Test with file upload interaction