Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/AUT-2673/display-image-inline-block #185

Closed
wants to merge 2 commits into from

Conversation

marpesia
Copy link

@marpesia marpesia commented Oct 31, 2022

Related to: AUT-2673

Description:
Display Image inline on Figure tag

Changes:
The Figure tag is a block tag, so the better approach is to fake the flow with CSS.

  • Add a display: flex property to the Feature and siblings elements wrapper, forcing the inline flow.

Companion PRs

How to check:

On Assets

  • Create an Asset with a text block. Add in the middle of the text an image. Play with the inline panel controls of the image to check if it is positioned correctly.
  • Check Preview.

On Items

  • Repeat the previous step on Assets.
  • Add the previously created Asset with the Figure image on the inline position to check the position of the Asset image inside the Item.
  • Check Preview

On Tests

  • Pending Preview ⚠️

@github-actions
Copy link

github-actions bot commented Nov 2, 2022

Version

Target Version 3.7.4
Last version 3.7.3

There are 0 BREAKING CHANGE, 0 feature, 2 fixes

@codecov-commenter
Copy link

Codecov Report

Merging #185 (f960edf) into develop (65a6bf5) will increase coverage by 0.08%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop     #185      +/-   ##
=============================================
+ Coverage      45.15%   45.24%   +0.08%     
  Complexity       163      163              
=============================================
  Files             20       20              
  Lines            516      515       -1     
=============================================
  Hits             233      233              
+ Misses           283      282       -1     
Impacted Files Coverage Δ
controller/Previewer.php 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@marpesia marpesia marked this pull request as draft November 2, 2022 20:03
@marpesia marpesia closed this Nov 3, 2022
@marpesia marpesia deleted the fix/AUT-2673/display-image-inline-block branch November 3, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants