Merge pull request #49 from oat-sa/develop

Develop
oat-sa · Oct 28, 2021 · 0a4b426 · 0a4b426
2 parents 1e26b5d + d6e0f78
commit 0a4b426
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+1.3.0
+-----
+
+* Added `milliseconds` to timestamp in `Score` JSON output
+
 1.2.0
 -----
 

diff --git a/src/Model/Score/Score.php b/src/Model/Score/Score.php
@@ -225,7 +225,7 @@ public function jsonSerialize(): array
                     'scoreGiven' => $this->scoreGiven,
                     'scoreMaximum' => $this->scoreMaximum,
                     'comment' => $this->comment,
-                    'timestamp' => $this->timestamp->format(DateTimeInterface::ATOM),
+                    'timestamp' => $this->timestamp->format(DateTimeInterface::RFC3339_EXTENDED),
                 ]
             ),
             static function ($value): bool {

diff --git a/tests/Unit/Model/Score/ScoreTest.php b/tests/Unit/Model/Score/ScoreTest.php
@@ -73,7 +73,7 @@ public function testDefaults(): void
                 'userId' => 'scoreUserIdentifier',
                 'activityProgress' => ScoreInterface::ACTIVITY_PROGRESS_STATUS_INITIALIZED,
                 'gradingProgress' => ScoreInterface::GRADING_PROGRESS_STATUS_NOT_READY,
-                'timestamp' => $this->now->format(DateTimeInterface::ATOM),
+                'timestamp' => $this->now->format(DateTimeInterface::RFC3339_EXTENDED),
             ],
             $this->subject->jsonSerialize()
         );
@@ -168,7 +168,7 @@ public function testJsonSerialize(): void
                 'scoreGiven' => (float)10,
                 'scoreMaximum' => (float)100,
                 'comment' => 'scoreComment',
-                'timestamp' => $this->now->format(DateTimeInterface::ATOM),
+                'timestamp' => $this->now->format(DateTimeInterface::RFC3339_EXTENDED),
                 'key' => 'value'
             ],
             $subject->jsonSerialize()
@@ -191,7 +191,7 @@ public function testJsonSerializeWithZeroValues(): void
                 'scoreGiven' => 0,
                 'scoreMaximum' => 0,
                 'comment' => 'scoreComment',
-                'timestamp' => $this->now->format(DateTimeInterface::ATOM),
+                'timestamp' => $this->now->format(DateTimeInterface::RFC3339_EXTENDED),
                 'key' => 'value'
             ],
             $subject->jsonSerialize()