refact: modified parameter names and used exception code

oat-sa · Jan 11, 2022 · 4a39d40 · 4a39d40
1 parent a1fbd2c
commit 4a39d40
Show file tree

Hide file tree

Showing 7 changed files with 28 additions and 28 deletions.
diff --git a/src/Serializer/LineItem/LineItemCollectionSerializer.php b/src/Serializer/LineItem/LineItemCollectionSerializer.php
@@ -41,10 +41,10 @@ class LineItemCollectionSerializer implements LineItemCollectionSerializerInterf
     private $jsonSerializer;
 
     public function __construct(
-        ?LineItemFactoryInterface $factory = null,
+        ?LineItemFactoryInterface $lineItemFactory = null,
         ?JsonSerializerInterface $jsonSerializer = null
     ) {
-        $this->lineItemFactory = $factory ?? new LineItemFactory();
+        $this->lineItemFactory = $lineItemFactory ?? new LineItemFactory();
         $this->jsonSerializer = $jsonSerializer ?? new JsonSerializer();
     }
 
@@ -58,7 +58,7 @@ public function serialize(LineItemCollectionInterface $collection): string
         } catch (RuntimeException $exception) {
             throw new LtiException(
                 sprintf('Error during line item collection serialization: %s', $exception->getMessage()),
-                0,
+                $exception->getCode(),
                 $exception
             );
         }
@@ -74,7 +74,7 @@ public function deserialize(string $data): LineItemCollectionInterface
         } catch (RuntimeException $exception) {
             throw new LtiException(
                 sprintf('Error during line item collection deserialization: %s', $exception->getMessage()),
-                0,
+                $exception->getCode(),
                 $exception
             );
         }

diff --git a/src/Serializer/LineItem/LineItemContainerSerializer.php b/src/Serializer/LineItem/LineItemContainerSerializer.php
@@ -42,10 +42,10 @@ class LineItemContainerSerializer implements LineItemContainerSerializerInterfac
     private $jsonSerializer;
 
     public function __construct(
-        ?LineItemFactoryInterface $factory = null,
+        ?LineItemFactoryInterface $lineItemFactory = null,
         ?JsonSerializerInterface $jsonSerializer = null
     ) {
-        $this->lineItemFactory = $factory ?? new LineItemFactory();
+        $this->lineItemFactory = $lineItemFactory ?? new LineItemFactory();
         $this->jsonSerializer = $jsonSerializer ?? new JsonSerializer();
     }
 
@@ -59,7 +59,7 @@ public function serialize(LineItemContainerInterface $container): string
         } catch (RuntimeException $exception) {
             throw new LtiException(
                 sprintf('Error during line item container serialization: %s', $exception->getMessage()),
-                0,
+                $exception->getCode(),
                 $exception
             );
         }
@@ -75,7 +75,7 @@ public function deserialize(string $data): LineItemContainerInterface
         } catch (RuntimeException $exception) {
             throw new LtiException(
                 sprintf('Error during line item container deserialization: %s', $exception->getMessage()),
-                0,
+                $exception->getCode(),
                 $exception
             );
         }

diff --git a/src/Serializer/LineItem/LineItemSerializer.php b/src/Serializer/LineItem/LineItemSerializer.php
@@ -40,10 +40,10 @@ class LineItemSerializer implements LineItemSerializerInterface
     private $jsonSerializer;
 
     public function __construct(
-        ?LineItemFactoryInterface $factory = null,
+        ?LineItemFactoryInterface $lineItemFactory = null,
         ?JsonSerializerInterface $jsonSerializer = null
     ) {
-        $this->lineItemFactory = $factory ?? new LineItemFactory();
+        $this->lineItemFactory = $lineItemFactory ?? new LineItemFactory();
         $this->jsonSerializer = $jsonSerializer ?? new JsonSerializer();
     }
 
@@ -57,7 +57,7 @@ public function serialize(LineItemInterface $lineItem): string
         } catch (RuntimeException $exception) {
             throw new LtiException(
                 sprintf('Error during line item serialization: %s', $exception->getMessage()),
-                0,
+                $exception->getCode(),
                 $exception
             );
         }
@@ -73,7 +73,7 @@ public function deserialize(string $data): LineItemInterface
         } catch (RuntimeException $exception) {
             throw new LtiException(
                 sprintf('Error during line item deserialization: %s', $exception->getMessage()),
-                0,
+                $exception->getCode(),
                 $exception
             );
         }

diff --git a/src/Serializer/Result/ResultCollectionSerializer.php b/src/Serializer/Result/ResultCollectionSerializer.php
@@ -41,10 +41,10 @@ class ResultCollectionSerializer implements ResultCollectionSerializerInterface
     private $jsonSerializer;
 
     public function __construct(
-        ?ResultFactoryInterface $factory = null,
+        ?ResultFactoryInterface $resultFactory = null,
         ?JsonSerializerInterface $jsonSerializer = null
     ) {
-        $this->resultFactory = $factory ?? new ResultFactory();
+        $this->resultFactory = $resultFactory ?? new ResultFactory();
         $this->jsonSerializer = $jsonSerializer ?? new JsonSerializer();
     }
 
@@ -58,7 +58,7 @@ public function serialize(ResultCollectionInterface $collection): string
         } catch (RuntimeException $exception) {
             throw new LtiException(
                 sprintf('Error during result collection serialization: %s', $exception->getMessage()),
-                0,
+                $exception->getCode(),
                 $exception
             );
         }
@@ -74,7 +74,7 @@ public function deserialize(string $data): ResultCollectionInterface
         } catch (RuntimeException $exception) {
             throw new LtiException(
                 sprintf('Error during result collection deserialization: %s', $exception->getMessage()),
-                0,
+                $exception->getCode(),
                 $exception
             );
         }

diff --git a/src/Serializer/Result/ResultContainerSerializer.php b/src/Serializer/Result/ResultContainerSerializer.php
@@ -42,10 +42,10 @@ class ResultContainerSerializer implements ResultContainerSerializerInterface
     private $jsonSerializer;
 
     public function __construct(
-        ?ResultFactoryInterface $factory = null,
+        ?ResultFactoryInterface $resultFactory = null,
         ?JsonSerializerInterface $jsonSerializer = null
     ) {
-        $this->resultFactory = $factory ?? new ResultFactory();
+        $this->resultFactory = $resultFactory ?? new ResultFactory();
         $this->jsonSerializer = $jsonSerializer ?? new JsonSerializer();
     }
 
@@ -59,7 +59,7 @@ public function serialize(ResultContainerInterface $container): string
         } catch (RuntimeException $exception) {
             throw new LtiException(
                 sprintf('Error during result container serialization: %s', $exception->getMessage()),
-                0,
+                $exception->getCode(),
                 $exception
             );
         }
@@ -75,7 +75,7 @@ public function deserialize(string $data): ResultContainerInterface
         } catch (RuntimeException $exception) {
             throw new LtiException(
                 sprintf('Error during result container deserialization: %s', $exception->getMessage()),
-                0,
+                $exception->getCode(),
                 $exception
             );
         }

diff --git a/src/Serializer/Result/ResultSerializer.php b/src/Serializer/Result/ResultSerializer.php
@@ -40,10 +40,10 @@ class ResultSerializer implements ResultSerializerInterface
     private $jsonSerializer;
 
     public function __construct(
-        ?ResultFactoryInterface $factory = null,
+        ?ResultFactoryInterface $resultFactory = null,
         ?JsonSerializerInterface $jsonSerializer = null
     ) {
-        $this->resultFactory = $factory ?? new ResultFactory();
+        $this->resultFactory = $resultFactory ?? new ResultFactory();
         $this->jsonSerializer = $jsonSerializer ?? new JsonSerializer();
     }
 
@@ -57,7 +57,7 @@ public function serialize(ResultInterface $result): string
         } catch (RuntimeException $exception) {
             throw new LtiException(
                 sprintf('Error during result serialization: %s', $exception->getMessage()),
-                0,
+                $exception->getCode(),
                 $exception
             );
         }
@@ -73,7 +73,7 @@ public function deserialize(string $data): ResultInterface
         } catch (RuntimeException $exception) {
             throw new LtiException(
                 sprintf('Error during result deserialization: %s', $exception->getMessage()),
-                0,
+                $exception->getCode(),
                 $exception
             );
         }

diff --git a/src/Serializer/Score/ScoreSerializer.php b/src/Serializer/Score/ScoreSerializer.php
@@ -40,10 +40,10 @@ class ScoreSerializer implements ScoreSerializerInterface
     private $jsonSerializer;
 
     public function __construct(
-        ?ScoreFactoryInterface $factory = null,
+        ?ScoreFactoryInterface $scoreFactory = null,
         ?JsonSerializerInterface $jsonSerializer = null
     ) {
-        $this->scoreFactory = $factory ?? new ScoreFactory();
+        $this->scoreFactory = $scoreFactory ?? new ScoreFactory();
         $this->jsonSerializer = $jsonSerializer ?? new JsonSerializer();
     }
 
@@ -57,7 +57,7 @@ public function serialize(ScoreInterface $score): string
         } catch (RuntimeException $exception) {
             throw new LtiException(
                 sprintf('Error during score serialization: %s', $exception->getMessage()),
-                0,
+                $exception->getCode(),
                 $exception
             );
         }
@@ -73,7 +73,7 @@ public function deserialize(string $data): ScoreInterface
         } catch (RuntimeException $exception) {
             throw new LtiException(
                 sprintf('Error during score deserialization: %s', $exception->getMessage()),
-                0,
+                $exception->getCode(),
                 $exception
             );
         }