Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TR-1412 XML-encode values – CG #294

Merged
merged 3 commits into from
Jul 16, 2021

Conversation

wazelin
Copy link
Member

@wazelin wazelin commented Jul 15, 2021

TR-1412

  • fix: use array element addition operand instead of calling array_push() function within qtism\data\storage\xml\Utils methods
  • fix: XML-encode a value before inserting it into DOM

This is a legacy counterpart to #293

How to test

  • author a test with Extended text interaction
  • publish the test and launch the delivery as a test taker
  • answer extended text interaction item with content containing non breaking spaces  , finish the test
  • verify that result extraction consumer processed results without failure

…h()` function within `qtism\data\storage\xml\Utils` methods

(cherry picked from commit df92ed9)
@wazelin wazelin force-pushed the fix/TR-1412/xml-encode-values-cg branch from f039e6c to a238ea8 Compare July 16, 2021 07:42
Copy link
Contributor

@bugalot bugalot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like an elegant solution!

Copy link
Contributor

@augustas augustas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

@wazelin wazelin merged commit b24986d into legacy Jul 16, 2021
@wazelin wazelin deleted the fix/TR-1412/xml-encode-values-cg branch July 16, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants